Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hosts spinning indefinitely #1446

Merged
merged 24 commits into from
Feb 23, 2024
Merged

Fix hosts spinning indefinitely #1446

merged 24 commits into from
Feb 23, 2024

Conversation

gzpcho
Copy link
Contributor

@gzpcho gzpcho commented Feb 6, 2024 •
edited
Loading

What?

  • Raw host info modal in host details page
  • API call to get ec2 tags and check if host is marked as "shame"
  • New UI icon for staled and failed hosts
  • Correct UI to match backend mapping ("Status" -> "State")

Why?

  • Prevent hosts from showing as spinning indefinitely once they come up

Test Plan

  • Verified changes in dev1 stage (see screenshots)

image

Screen.Recording.2024-02-05.at.2.53.36.PM.mov

CDP-7249
CDP-7471

@gzpcho gzpcho requested a review from a team as a code owner February 6, 2024 03:51
@github-actions github-actions bot added the deploy-board Includes changes to deploy-board label Feb 6, 2024
rfleur01
rfleur01 previously approved these changes Feb 8, 2024
View reviewed changes
tylerwowen
tylerwowen previously approved these changes Feb 13, 2024
View reviewed changes
ntascii
ntascii previously approved these changes Feb 13, 2024
View reviewed changes
@gzpcho gzpcho dismissed stale reviews from ntascii and tylerwowen via 65f9f0c February 13, 2024 23:09
@gzpcho gzpcho merged commit 7e7480d into master Feb 23, 2024
5 checks passed
@gzpcho gzpcho deleted the iroquebert/cdp-7249 branch February 23, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntascii ntascii ntascii approved these changes

@tylerwowen tylerwowen tylerwowen left review comments

@rfleur01 rfleur01 Awaiting requested review from rfleur01

Assignees
No one assigned
Labels
deploy-board Includes changes to deploy-board
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gzpcho @tylerwowen @ntascii @rfleur01